<table><tr><td style="">mwolff accepted this revision.<br />mwolff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4122" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>one minor code style nitpick, then it's ready to go</p>

<p>thanks!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4122#inline-17604" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">idealcontroller.cpp:122</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">      <span class="n">toolBar</span><span style="color: #aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span class="n">cg</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="n">dockObjectName</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">      <span class="n">connect</span><span class="p">(</span><span class="n">toolBar</span><span style="color: #aa2211">-></span><span class="n">toggleViewAction</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">QAction</span><span style="color: #aa2211">::</span><span class="n">toggled</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span class="n">toolBar</span><span class="p">,</span> <span class="n">dockObjectName</span><span class="p">](){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">KConfigGroup</span> <span class="n">cg</span><span class="p">(</span><span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(),</span> <span style="color: #766510">"UiSettings/Docks/ToolbarEnabled"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please introduce a newline before the this and indent the lambda body</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">connect(toolBar->toggleViewAction(), &QAction::toggled,
        this, [toolBar, dockObjectName]() {
            ...
        });</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4122" rel="noreferrer">https://phabricator.kde.org/D4122</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>tcanabrava, apol, antonanikin, kfunk, KDevelop, mwolff<br /><strong>Cc: </strong>mwolff, antonanikin, kdevelop-devel<br /></div>