D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.


  Whatever. Go for it.

INLINE COMMENTS

> aaronpuchert wrote in multilevellistview.cpp:448-451
> As soon as I commit https://phabricator.kde.org/D9042 this will generate a warning. I'd just remove this label and add `Q_UNREACHABLE()` after the switch statement.

+1

> multilevellistview.h:46
>  public:
> +    enum LastLevelViewModus {
> +        SubTrees,      ///< Shows complete subtree for each child. Only leafs are selectable.

'Modus' is non-existent in English. => 'Mode'?

> multilevellistview.h:120
>       */
> -    void setLastModelsFilterBehavior(KSelectionProxyModel::FilterBehavior filter);
> +    void setLastLevelViewModus(LastLevelViewModus modus);
> +

Dito (and more occasions below)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D9316

To: kossebau, #kdevelop, kfunk, brauch
Cc: aaronpuchert, brauch, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171219/23bb354a/attachment.html>