D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil
Aaron Puchert
noreply at phabricator.kde.org
Mon Dec 18 23:34:49 UTC 2017
aaronpuchert added a comment.
I'm fine with the change otherwise, but I think @kfunk and/or @brauch should have a chance to revise or reaffirm their position.
INLINE COMMENTS
> multilevellistview.cpp:448-451
> + default:
> + // someone added a new enum value? adapt
> + Q_ASSERT(false);
> + return KSelectionProxyModel::SubTreesWithoutRoots;
As soon as I commit https://phabricator.kde.org/D9042 this will generate a warning. I'd just remove this label and add `Q_UNREACHABLE()` after the switch statement.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D9316
To: kossebau, #kdevelop, kfunk, brauch
Cc: aaronpuchert, brauch, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171218/553ce10f/attachment.html>
More information about the KDevelop-devel
mailing list