D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.


  To be honest, I'm not sure I like this change. It's adding code which we need to maintain (what if the `KSelectionProxyModel::FilterBehavior` enum is extended?) for very, very little gain.
  
  I'd propose to just abandon this change, sorry.

INLINE COMMENTS

> kossebau wrote in multilevellistview.cpp:465
> That dynamic_cast without testing the result deserves a separate fixing commit, possibly with global check for similar ones. Noted, so you do not have to :)

Right, `d->proxies.last()` can potentially be an instance not inheriting `KSelectionProxyModel` (iiuc when passing `1` to `MultiLevelListView::setLevels(...)`). Someone should check this code :)

> multilevellistview.h:46
>  public:
> +    // clone of KSelectionProxyModel::FilterBehavior, to hide implementation detail
> +    // and keep KF5::ItenModels out of public link interface

It's not an implementation detail if we pass the exact same value through to `KSelectionProxyModel`.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D9316

To: kossebau, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171213/7fd99c32/attachment-0001.html>