D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Dec 13 17:06:53 UTC 2017


kossebau added inline comments.

INLINE COMMENTS

> multilevellistview.cpp:465
> +    const auto spmFilterBehavior = asSelectionProxyModelFilterBehavior(filterBehavior);
> +    dynamic_cast<KSelectionProxyModel*>(d->proxies.last())->setFilterBehavior(spmFilterBehavior);
>  }

That dynamic_cast without testing the result deserves a separate fixing commit, possibly with global check for similar ones. Noted, so you do not have to :)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D9316

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171213/a991a437/attachment.html>


More information about the KDevelop-devel mailing list