D9297: Fix #387391: Random responses from the C/C++ language support

[Venca B Spam]

vbspam created this revision.
vbspam added a reviewer: KDevelop.
vbspam added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Fix #387391: Random responses from the C/C++ language support when using
  symbolic links to CMake sub-projects (https://bugs.kde.org/show_bug.cgi?id=387391)
  
  Although the original idea of using canonicalFilePath() sounds as best solution, it looks like KDevelop uses absoluteFilePath() in C/C++ language support query url [1] to related build system artifact.
  
  [1] file: plugins/clang/clangparsejob.cpp:119 method: ProjectFileItem* findProjectFileItem(const IndexedString& url, bool*hasBuildSystemInfo)
  ( )

TEST PLAN
  Being new to KDevelop I have no idea what should be here.
  
  Within the bug report I prepared steps to reproduce the bug.
  
  I also prepared minimal and complex projects which may serve as this test plan test cases.
  
  For details please see the bug  #387391 (https://bugs.kde.org/show_bug.cgi?id=387391).
  
  I also have a question which I put into the bug report which is related to this patch. Simply: although I know why my solution works, it is not clear why the original solution does not work now. I guess that the query uses newly url with absoluteFilePath instead.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D9297

AFFECTED FILES
  plugins/cmake/cmakeserverimportjob.cpp

To: vbspam, #kdevelop
Cc: kdevelop-devel, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171212/653330bd/attachment.html>