D7597: added possibility to specify local path

[Kevin Funk]

kfunk added a comment.


  Rest LGTM, but I just looked briefly.

INLINE COMMENTS

> uploadprofiledlg.cpp:137
> +    QUrl chosenDir = QFileDialog::getExistingDirectoryUrl(this, QString(), m_ui->lineLocalPath->text());
> +#else
> +    QFileDialog dialog(this);

#else path not needed, we require Qt 5.5

> uploadprofiledlg.h:69
> +    
> +    QUrl* projectPath;
>  };

Unused?

> uploadprofileitem.h:23
>          UrlRole = Qt::UserRole+1,
>          IsDefaultRole = Qt::UserRole+2,
> +        ProfileNrRole = Qt::UserRole+3,

Just remove Qt::UserRole+2 and the enum values below.

REPOSITORY
  R69 KDevelop Upload

REVISION DETAIL
  https://phabricator.kde.org/D7597

To: schnere, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170830/110de5b0/attachment.html>