<table><tr><td style="">kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7597" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Rest LGTM, but I just looked briefly.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7597#inline-31104" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">uploadprofiledlg.cpp:137</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QUrl</span> <span class="n">chosenDir</span> <span style="color: #aa2211">=</span> <span class="n">QFileDialog</span><span style="color: #aa2211">::</span><span class="n">getExistingDirectoryUrl</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">lineLocalPath</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QFileDialog</span> <span style="color: #004012">dialog</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">#else path not needed, we require Qt 5.5</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7597#inline-31103" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">uploadprofiledlg.h:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QUrl</span><span style="color: #aa2211">*</span> <span class="n">projectPath</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unused?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7597#inline-31105" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">uploadprofileitem.h:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">UrlRole</span> <span style="color: #aa2211">=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">UserRole</span><span style="color: #aa2211">+</span><span style="color: #601200">1</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">IsDefaultRole</span> <span style="color: #aa2211">=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">UserRole</span><span style="color: #aa2211">+</span><span style="color: #601200">2</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">ProfileNrRole</span> <span style="color: #aa2211">=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">UserRole</span><span style="color: #aa2211">+</span><span style="color: #601200">3</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">ProfileNrRole</span> <span style="color: #aa2211">=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">UserRole</span><span style="color: #aa2211">+</span><span style="color: #601200">3<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just remove Qt::UserRole+2 and the enum values below.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R69 KDevelop Upload</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7597" rel="noreferrer">https://phabricator.kde.org/D7597</a></div></div><br /><div><strong>To: </strong>schnere, KDevelop<br /><strong>Cc: </strong>kfunk, kdevelop-devel<br /></div>