D7554: Outoutview CmakeMultiline expression accidentally hits on CMake Error
noreply at phabricator.kde.org
Sat Aug 26 06:53:55 UTC 2017
volden created this revision.
volden added a project: KDevelop.
Upon further testing of Axels patch I stumbled upon a buglet introduced by commit c1cf56dd703cf83594347737c376c6f209ebf9b0
The expression intended for catching CMakeMultiline errors e.g.:
CMake Error: Error in cmake code at
/some/path with spaces/to/a/project/CMakeLists.txt:10:
Where the regex would hit on the second line.
Now it also hits on lines such as this.
CMake Error at SecondSubDir/CMakeLists.txt:1:
Which means that the filename is extracted wrong and the user will be sent to a new file instead of the file with the error.
I have changed the regex in question and added a unittest that catches this scenario
Unittests updated with testcase showing the isse
To: volden, #kdevelop
Cc: kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel