D7040: OutputFilteringStrategies: Parse cmake output for project directory and use it in OutputView
noreply at phabricator.kde.org
Sat Aug 12 22:42:46 UTC 2017
akellermann updated this revision to Diff 18068.
akellermann added a comment.
I had access to a windows machine running kdevelop and had a look at the format of cmake output there. So this patch
1. updates the regex to work with cmake project paths on Windows (format is D:/path/to/proj)
2. adds unit tests for Linux paths with and without spaces
3. adds unit tests for Windows paths with and without spaces
Unfortunately the Windows tests don't work at the moment (and are therefore commented out), as class Path used in CompilerFilterStrategyPrivate to store paths mangles Windows paths starting with drive letters (transforms e.g. `D:/` to `d:///`). I'm not sure how to solve this, or if this should be solved with this patch at all, as it blows the scope out of proportion.
CHANGES SINCE LAST UPDATE
To: akellermann, kfunk
Cc: volden, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel