D7158: Use custom icon border context menu, when no mark is present

Christoph Roick noreply at phabricator.kde.org
Wed Aug 9 19:37:06 UTC 2017

croick added a comment.

  One solution could be to provide the icons in `KateIconBorder::showMarkMenu` directly, which I think would be an improvement in any case. What do you think?


> kfunk wrote in breakpointmodel.cpp:168
> That menu is already provided by KTextEditor, right? This adds half-duplicated code from KTextEditor (cf. `KateIconBorder::showMarkMenu`); I'm not sure this is something we'd like to maintain...
> I don't fully understand how this adds the icons to the `[ ] Breakpoint` and `[ ] Bookmark` actios on the top-level menu though(?), could you elaborate?
> I'd be happier if we could simplify this patch more.

Yes, basically it's the same menu in https://phabricator.kde.org/tag/ktexteditor/ but with icons.

The icons are displayed, because since https://phabricator.kde.org/R39:3b202d26f2eef21316c733ea8843e511fa18da5f clicks on no marks are also emitted and `BreakpointModel::markContextMenuRequested` now only returns unhandled when further mark types are editable. Before, `BreakpointModel` didn't even notice.

  R33 KDevPlatform


To: croick, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170809/92d31268/attachment-0001.html>

More information about the KDevelop-devel mailing list