D7158: Use custom icon border context menu, when no mark is present
noreply at phabricator.kde.org
Tue Aug 8 21:43:11 UTC 2017
kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.
> + // add menu for selection of default mark type
> + QMenu selectDefaultMark;
That menu is already provided by KTextEditor, right? This adds half-duplicated code from KTextEditor (cf. `KateIconBorder::showMarkMenu`); I'm not sure this is something we'd like to maintain...
I don't fully understand how this adds the icons to the `[ ] Breakpoint` and `[ ] Bookmark` actios on the top-level menu though(?), could you elaborate?
I'd be happier if we could simplify this patch more.
To: croick, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel