D7158: Use custom icon border context menu, when no mark is present

Kevin Funk noreply at phabricator.kde.org
Tue Aug 8 21:43:11 UTC 2017

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.


> breakpointmodel.cpp:168
> +
> +    // add menu for selection of default mark type
> +    QMenu selectDefaultMark;

That menu is already provided by KTextEditor, right? This adds half-duplicated code from KTextEditor (cf. `KateIconBorder::showMarkMenu`); I'm not sure this is something we'd like to maintain...

I don't fully understand how this adds the icons to the `[ ] Breakpoint` and `[ ] Bookmark` actios on the top-level menu though(?), could you elaborate?

I'd be happier if we could simplify this patch more.

  R33 KDevPlatform


To: croick, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170808/ca382e3b/attachment.html>

More information about the KDevelop-devel mailing list