D7040: OutputFilteringStrategies: Parse cmake output for project directory and use it in OutputView
noreply at phabricator.kde.org
Wed Aug 9 19:00:32 UTC 2017
volden added a comment.
Some initial thoughts:
Unittests are needed. As a minimum testCompilerFilterstrategyUrlFromAction_data should be extended with something that tests this new action.
In the first part of the regex, why use (?:/|\\\\)cmake and not just do (?:)cmake
Did a quick test on the string:
/home/mvo/projects/TestCmake/build> /usr/bin/cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_BUILD_TYPE=Debug /home/mvo/projects/TestCmake
on regex101. The debugger there says 156 steps vs 146 steps to match to "cmake" for the two regexes respectively. Plus the latter is IMHO much nicer to read.
Again, thanks for looking into this.
To: akellermann, kfunk
Cc: volden, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel