D7179: Mac: fixing sortedDocumentList menu doesn't change focus (WIP)
noreply at phabricator.kde.org
Mon Aug 7 13:37:47 UTC 2017
kfunk added a comment.
In https://phabricator.kde.org/D7179#133279, @rjvbb wrote:
> So the signal blocker cannot be removed on Linux at least.
Thanks for confirming.
> I wonder though, isn't there a risk anyway of these functions calling each other in a loop? Couldn't both functions just check if the given widget is already current (or given view is already the active one) and return immediately if that's the case?
Makes sense to me. Though it's enough if you make sure `activateView(...)` isn't emitted twice in this case in `Container::widgetActivated` only. I think that should work.
> Removing the signal blocker would still lead to activeView() being called twice in that case, but at least the 2nd invocation shouldn't do anything in that case.
To: rjvbb, #kdevelop
Cc: kfunk, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel