D7061: Improve search in documentation view: kate-look, hide on ESC, live search

[Sven Brauch]

brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Looks good to me -- I think we should try to make the search more discoverable though, IMO in the navigation bar up there it looks like it is a global search (i.e. not on the current page). All the other buttons in that bar are for navigation between pages, just this one is for navigation inside the page.

INLINE COMMENTS

> standarddocumentationview.cpp:186
>  
> +void StandardDocumentationView::searchLive(const QString& text, DocumentationFindWidget::FindOptions options)
> +{

a bit unconventional naming, I'd simply go for something like "updateSearchPattern"

REPOSITORY
  R33 KDevPlatform

BRANCH
  improvedocsearch

REVISION DETAIL
  https://phabricator.kde.org/D7061

To: kossebau, #kdevelop, brauch
Cc: brauch, igorkushnir, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170805/e5500024/attachment.html>