Review Request 129829: refactor ContextMenuExtension::populateMenu to get rid of adding NULL Qaction warnings from QWidget::insertAction

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129829/
-----------------------------------------------------------

(Updated Aug. 2, 2017, 1:12 p.m.)


Status
------

This change has been discarded.


Review request for KDevelop.


Repository: kdevplatform


Description
-------

When extensions like the debugger plugin(s) are not loaded attempts can be made to insert NULL QAction pointers into the context menu.
This patch modifies ContextMenuExtension::populateMenu() to avoid that.

Currently I filter out null pointers in a new `addContextActions` function, but maybe this should in fact be taken care of by `ContextMenuExtension::addAction()`?

Is it useful to print a warning or debug message about this kind of event, or is it in fact an accepted/able situation that is an expected outcome when plugins are not loaded?


Diffs
-----

  interfaces/contextmenuextension.cpp 8dc9a1135 

Diff: https://git.reviewboard.kde.org/r/129829/diff/


Testing
-------

Works as intended.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170802/3f01aa34/attachment.html>