Review Request 129829: refactor ContextMenuExtension::populateMenu to get rid of adding NULL Qaction warnings from QWidget::insertAction

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129829/#review103533
-----------------------------------------------------------



A variant of this patch has been already pushed to kdevplatform as https://cgit.kde.org/kdevplatform.git/commit/?id=576760bff6b91f3ea8121842a4d56036151a0f79 so please discard this request.

- Friedrich W. H. Kossebau


On Jan. 14, 2017, 1 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129829/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2017, 1 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> When extensions like the debugger plugin(s) are not loaded attempts can be made to insert NULL QAction pointers into the context menu.
> This patch modifies ContextMenuExtension::populateMenu() to avoid that.
> 
> Currently I filter out null pointers in a new `addContextActions` function, but maybe this should in fact be taken care of by `ContextMenuExtension::addAction()`?
> 
> Is it useful to print a warning or debug message about this kind of event, or is it in fact an accepted/able situation that is an expected outcome when plugins are not loaded?
> 
> 
> Diffs
> -----
> 
>   interfaces/contextmenuextension.cpp 8dc9a1135 
> 
> Diff: https://git.reviewboard.kde.org/r/129829/diff/
> 
> 
> Testing
> -------
> 
> Works as intended.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170802/db9081f7/attachment.html>