D2621: GitHub Two Factor Authentication

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.


  LGTM. Though I can't test myself, I don't have 2FA activated on Github...
  
  Would be grateful if another person could test this patch.

INLINE COMMENTS

> zhigalin wrote in ghresource.cpp:173
> > https://developer.github.com/v3/auth/ says it's X-GitHub-OTP: required;
> 
> Than it lies :)
> It's actually lowercase.
> Anyway, just making it case-insensitive...

Ugh.

Please add a note then :)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D2621

To: zhigalin, mwolff, kfunk, ial0
Cc: mwolff, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170802/8fbb69c8/attachment.html>