<table><tr><td style="">kfunk accepted this revision.<br />kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2621" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>LGTM. Though I can't test myself, I don't have 2FA activated on Github...</p>
<p>Would be grateful if another person could test this patch.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2621#inline-28809" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zhigalin</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ghresource.cpp:173</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;"><a href="https://developer.github.com/v3/auth/" class="remarkup-link" target="_blank" rel="noreferrer">https://developer.github.com/v3/auth/</a> says it's X-GitHub-OTP: required;</p></blockquote>
<p style="padding: 0; margin: 8px;">Than it lies :)<br />
It's actually lowercase.<br />
Anyway, just making it case-insensitive...</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ugh.</p>
<p style="padding: 0; margin: 8px;">Please add a note then :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2621" rel="noreferrer">https://phabricator.kde.org/D2621</a></div></div><br /><div><strong>To: </strong>zhigalin, mwolff, kfunk, ial0<br /><strong>Cc: </strong>mwolff, kfunk, kdevelop-devel<br /></div>