Review Request 121285: Use new style connect in KActionCollection::addAction()

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121285/#review103525
-----------------------------------------------------------



Alex, could you help clean up of reviewboard and discard this patch? Given
* it no longer applies (e.g. due to clang-based fixes which already cared for porting away from string-based connect)
* used KActionCollection API might still need a while until it is part of min required version in KDevelop
* by nature this patch is more of a code simplification (after all the template method expands to same C++ code)
this patch could be redone in little time once it will can be taken to use, so keeping this old variant around does not have much value.
Agreed? If so, please note this as discarded, only admin & author can do that :)

- Friedrich W. H. Kossebau


On Nov. 28, 2014, 8:58 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121285/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2014, 8:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Use new style connect in KActionCollection::addAction()
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eaf32e7234ba7530e363ef07e75970ec4d21c0cc 
>   language/codegen/applychangeswidget.cpp c6460db12e6faba1115d7eb23f940d9a837ecea8 
>   plugins/appwizard/appwizardplugin.cpp e8e9472caa62370191647bdc6fbc456837f0e96f 
>   plugins/codeutils/codeutilsplugin.cpp 49efa7731988dfa611049b8c75033da10e32462b 
>   plugins/documentswitcher/documentswitcherplugin.cpp e4592377cc355c2a3f5d2f7b60c397094140de85 
>   shell/mainwindow_p.cpp 82429aedaf7ff8d5692037e9c77c9028131b0c32 
> 
> Diff: https://git.reviewboard.kde.org/r/121285/diff/
> 
> 
> Testing
> -------
> 
> This requires https://git.reviewboard.kde.org/r/121283/
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170802/6d2845f0/attachment.html>