D7034: Add callable type to PHP
Alexander Zhigalin
noreply at phabricator.kde.org
Wed Aug 2 09:11:50 UTC 2017
zhigalin accepted this revision.
zhigalin added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> mtijink wrote in duchain.cpp:751
> Ah ok, you're correct. But that's not due to a problem in this code, but problems in the `ExpressionVisitor`: it skips most operators, such that the resulting type is that of the last appearing variable/literal. Thus, it applies the type of `$i` instead of the result of calling the function.
>
> For example, `function foo() { $i = function () {}; return $i(); }` yields type `void () foo ()`, which also is incorrect.
Okay then, commiting
REPOSITORY
R52 KDevelop: PHP Support
BRANCH
add_callable_type
REVISION DETAIL
https://phabricator.kde.org/D7034
To: mtijink, #kdevelop, zhigalin
Cc: zhigalin, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170802/03f563ea/attachment.html>
More information about the KDevelop-devel
mailing list