D5491: Improve detection of builtin defines from compiler command

[Aaron Puchert]

aaronpuchert added a comment.


  It might be that some OpenCL compilers support "clx.y", but the standard doesn't seem to allow it. (Even older standards don't: https://www.khronos.org/registry/OpenCL/sdk/1.1/docs/man/xhtml/clBuildProgram.html#idp145296)

INLINE COMMENTS

> gcclikecompiler.cpp:63
> +                       standardVersion.startsWith(QLatin1String("CL"))) {
> +                language = minusXCL();
> +            } else if (standardVersion.startsWith(QLatin1String("cuda"))) {

My understanding is that it must start with "CL", not "cl". (https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/clCompileProgram.html#id-1.6.18)

> test_compilerprovider.cpp:322
> +    checkCStandard("cl1.2", "199901L", true, {{"__OPENCL_C_VERSION__", "120"}});
> +    checkCStandard("cl2.0", "199901L", true, {{"__OPENCL_C_VERSION__", "200"}});
> +    checkCStandard("CL", "199901L", true, {{"__OPENCL_C_VERSION__", "100"}});

Again, I think it must be capital letters. This should be unnecessary.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5491

To: arichardson, #kdevelop, kfunk, mwolff
Cc: aaronpuchert, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170418/4ce836ed/attachment.html>