Review Request 128201: Improved StatusbarProgressDidget that looks better on OS X and Linux

René J.V. Bertin rjvbertin at
Sun Sep 11 12:39:42 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 11, 2016, 2:39 p.m.)

Review request for KDevelop and David Faure.


The recent change to replace QPushButton with a QToolButton required a few tweaks to this patch.

I've also introduced a small new change that should be useful on OS X and any other set-up where the requested go-up icon is missing from the active icon theme. In case the lookup fails, the button will use Qt::UpArrow.

I'm still convinced that the proposed changes give more well-balanced look to the progress widget, with notably better size alignment between the progressbar and the icon.

I'm less convinced by the borderless look at least with the go-up icon from the icon theme I use. I think I actually prefer the Qt::UpArrow look. Using that solution everywhere would also make the Macintosh style specific code block redundant.

I'll be adding 2 new screenshots.

Repository: kdevplatform


I came across this old bit of code, judging from the use of the deprecated `Q_OS_MAC` token. 
Some quick testing suggests that using `WA_LayoutUsesWidgetRect` achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the `macintosh` widget style btw, rather than "are we running on OS X").

Diffs (updated)

  shell/progresswidget/statusbarprogresswidget.cpp 42a58cf 



On OS X and Linux, with the native theme (Qt 5.6.x) as well as QtCurve, Breeze and Oxygen.

File Attachments (updated)

OS X/Mac native *without* the patch
stock widget under Linux (same layout using Breeze)
OS X/native with the new patch
OS X using QtCurve with the new patch
Linux, Breeze, new patch
Linux, QtCurve, new patch
Linux, Oxygen, new patch
Linux, Breeze + Breeze icons, new patch
Linux, QtCurve + Breeze icons, new patch
Linux,Oxygen+Breeze icons, new patch
Linux, Breeze, new patch with maximumHeight from progressBar->sizeHint().height()
X11, Breeze style + icons
X11, Oxygen style, Breeze icons
X11, QtCurve style, Breeze icons
X11, Oxygen style & icons
X11, Oxygen style & icons, expanded state
X11, Breeze, no "additional adjustments"
X11, Oxygen, taller progbar due to "no additional adjustments"
progress widget under the pure native Macintosh style, using Qt::UpArrow
progress widget under Breeze, using Qt::UpArrow


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list