[Differential] [Requested Changes To] D2634: [kdevplatform] Add ability to show ProblemsView with selected model data.

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> problemreporterplugin.cpp:156
> +{
> +    auto w = dynamic_cast<ProblemsView*>(core()->uiController()->findToolView(i18n("Problems"), m_factory));
> +    w->showModel(name);

This definitely needs to check against w being a nullptr.

> problemsview.cpp:357
> +{
> +    for (int idx = 0; idx < m_tabWidget->count(); ++idx) {
> +        if (nameFromLabel(m_tabWidget->tabText(idx)) == name) {

Almost copied code from `ProblemsView::onModelRemoved`.

Introduce a `tabIndexForName(const QString&)` function, called from both `ProblemsView::onModelRemoved` and here.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2634

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, mwolff, #kdevelop, kfunk
Cc: kfunk, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160908/11478163/attachment-0001.html>