<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a reviewer: kfunk.<br />kfunk added inline comments.<br />This revision now requires changes to proceed.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2634" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2634#inline-10575" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemreporterplugin.cpp:156</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">auto</span> <span class="n">w</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">dynamic_cast</span><span style="color: #aa2211"><</span><span class="n">ProblemsView</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">core</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">uiController</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">findToolView</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Problems"</span><span class="p">),</span> <span class="n">m_factory</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">w</span><span style="color: #aa2211">-></span><span class="n">showModel</span><span class="p">(</span><span class="n">name</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This definitely needs to check against w being a nullptr.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2634#inline-10576" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemsview.cpp:357</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">idx</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="n">idx</span> <span style="color: #aa2211"><</span> <span class="n">m_tabWidget</span><span style="color: #aa2211">-></span><span class="n">count</span><span class="p">();</span> <span style="color: #aa2211">++</span><span class="n">idx</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">nameFromLabel</span><span class="p">(</span><span class="n">m_tabWidget</span><span style="color: #aa2211">-></span><span class="n">tabText</span><span class="p">(</span><span class="n">idx</span><span class="p">))</span> <span style="color: #aa2211">==</span> <span class="n">name</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Almost copied code from <tt style="background: #ebebeb; font-size: 13px;">ProblemsView::onModelRemoved</tt>.</p>

<p style="padding: 0; margin: 8px;">Introduce a <tt style="background: #ebebeb; font-size: 13px;">tabIndexForName(const QString&)</tt> function, called from both <tt style="background: #ebebeb; font-size: 13px;">ProblemsView::onModelRemoved</tt> and here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2634" rel="noreferrer">https://phabricator.kde.org/D2634</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>antonanikin, mwolff, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, mwolff, kdevelop-devel<br /></div>