[Differential] [Commented On] D2618: [kdevplatform] fix plugins loading

[mwolff (Milian Wolff)]

mwolff added a comment.


  still lgtm, one minor style issue only

INLINE COMMENTS

> plugincontroller.cpp:248
> +        // in all other cases: figure out if we want to load that plugin by default
> +        const bool isDefaultPlugin = ShellExtension::getInstance()->defaultPlugins().isEmpty()
> +            || ShellExtension::getInstance()->defaultPlugins().contains(info.pluginId());

please introduce a temporary for the default plugins map

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  5.0

REVISION DETAIL
  https://phabricator.kde.org/D2618

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, antonanikin, mwolff, #kdevelop
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160906/b19cfa72/attachment.html>