<table><tr><td style="">mwolff added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2618" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>still lgtm, one minor style issue only</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2618#inline-10543" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugincontroller.cpp:248</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #74777d">// in all other cases: figure out if we want to load that plugin by default</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">bool</span> <span class="n">isDefaultPlugin</span> <span style="color: #aa2211">=</span> <span class="n">ShellExtension</span><span style="color: #aa2211">::</span><span class="n">getInstance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">defaultPlugins</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa2211">||</span> <span class="n">ShellExtension</span><span style="color: #aa2211">::</span><span class="n">getInstance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">defaultPlugins</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">info</span><span class="p">.</span><span class="n">pluginId</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please introduce a temporary for the default plugins map</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>BRANCH</strong><div><div>5.0</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2618" rel="noreferrer">https://phabricator.kde.org/D2618</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kfunk, antonanikin, mwolff, KDevelop<br /><strong>Cc: </strong>mwolff, kdevelop-devel<br /></div>