Review Request 128846: Switch to to the new ECM template function and clean up the preview images

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128846/#review98926
-----------------------------------------------------------



+1 from me

- Marco Martin


On Sept. 6, 2016, 11:02 a.m., Simon Wächter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128846/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 11:02 a.m.)
> 
> 
> Review request for KDevelop and Marco Martin.
> 
> 
> Repository: kapptemplate
> 
> 
> Description
> -------
> 
> 1.) Switch to the new ECM kde_package_app_templates function and remove the old KAppTemplate kapptemplate_add_app_templates CMake Macro
> 
> 2.) Clean up the images + improve naming. Additionally I will also submit a patch for kde_package_app_templates that will automatically include the preview images into the template bundle (If one is definied in the *.kdevtempate file)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 739149d 
>   cmake/modules/COPYING-CMAKE-SCRIPTS 4b41776 
>   cmake/modules/KAppTemplateMacro.cmake 03a35a7 
>   src/templates/C++/CMakeLists.txt f4ee99a 
>   src/templates/C++/akonadiresource/akonadi-resources.png 8513893 
>   src/templates/C++/akonadiresource/akonadiresource.kdevtemplate ffa183d 
>   src/templates/C++/akonadiresource/akonadiresource.png PRE-CREATION 
>   src/templates/C++/akonadiserializer/akonadi-serializer.png bad28b7 
>   src/templates/C++/akonadiserializer/akonadiserializer.kdevtemplate 3ba519d 
>   src/templates/C++/akonadiserializer/akonadiserializer.png PRE-CREATION 
>   src/templates/C++/kapp4-qml/kapp4-qml.kdevtemplate b853241 
>   src/templates/C++/kapp4-qml/kapp4-qml.png PRE-CREATION 
>   src/templates/C++/kapp4-qml/kapp4.png cb40c34 
>   src/templates/C++/ktexteditor/_ktexteditor.png PRE-CREATION 
>   src/templates/C++/ktexteditor/ktexteditor.kdevtemplate 90e7d3b 
>   src/templates/C++/ktexteditor/ktexteditor.png PRE-CREATION 
>   src/templates/CMakeLists.txt 1c308c9 
> 
> Diff: https://git.reviewboard.kde.org/r/128846/diff/
> 
> 
> Testing
> -------
> 
> Deleted all old templates, clean install + creation of a new application
> 
> 
> Thanks,
> 
> Simon Wächter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160906/9b0df465/attachment-0001.html>