Review Request 128846: Switch to to the new ECM template function and clean up the preview images

Simon Wächter waechter.simon at gmail.com
Tue Sep 6 11:02:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128846/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 1:02 p.m.)


Review request for KDevelop and Marco Martin.


Changes
-------

Require the ECM version


Repository: kapptemplate


Description
-------

1.) Switch to the new ECM kde_package_app_templates function and remove the old KAppTemplate kapptemplate_add_app_templates CMake Macro

2.) Clean up the images + improve naming. Additionally I will also submit a patch for kde_package_app_templates that will automatically include the preview images into the template bundle (If one is definied in the *.kdevtempate file)


Diffs (updated)
-----

  CMakeLists.txt 739149d 
  cmake/modules/COPYING-CMAKE-SCRIPTS 4b41776 
  cmake/modules/KAppTemplateMacro.cmake 03a35a7 
  src/templates/C++/CMakeLists.txt f4ee99a 
  src/templates/C++/akonadiresource/akonadi-resources.png 8513893 
  src/templates/C++/akonadiresource/akonadiresource.kdevtemplate ffa183d 
  src/templates/C++/akonadiresource/akonadiresource.png PRE-CREATION 
  src/templates/C++/akonadiserializer/akonadi-serializer.png bad28b7 
  src/templates/C++/akonadiserializer/akonadiserializer.kdevtemplate 3ba519d 
  src/templates/C++/akonadiserializer/akonadiserializer.png PRE-CREATION 
  src/templates/C++/kapp4-qml/kapp4-qml.kdevtemplate b853241 
  src/templates/C++/kapp4-qml/kapp4-qml.png PRE-CREATION 
  src/templates/C++/kapp4-qml/kapp4.png cb40c34 
  src/templates/C++/ktexteditor/_ktexteditor.png PRE-CREATION 
  src/templates/C++/ktexteditor/ktexteditor.kdevtemplate 90e7d3b 
  src/templates/C++/ktexteditor/ktexteditor.png PRE-CREATION 
  src/templates/CMakeLists.txt 1c308c9 

Diff: https://git.reviewboard.kde.org/r/128846/diff/


Testing
-------

Deleted all old templates, clean install + creation of a new application


Thanks,

Simon Wächter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160906/91b78653/attachment.html>


More information about the KDevelop-devel mailing list