[Differential] [Requested Changes To] D3205: Fix context help for template data types

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> identifier.h:194
>  
> -  QString toString() const;
> +  QString toString(bool addTemplateIdentifiers = true) const;
>  

Better add an enum for the string formatting options, e.g.:

  enum StringFormattingOption {
      AddTemplateIdentifiers = 0,
      IgnoreExplicitelyGlobal = 1 << 0
  };
  Q_DECLARE_FLAGS(StringFormattingOptions StringFormattingOption)
  
  // ...
  
  QString toString(StringFormattingOptions options) 

Note: We have to push this patch to master, since it's an ABI incompatible change. OR (if we want to have it in 5.0, which makes sense) create extra methods which have the additional parameter, keep the original method signatures untouched.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3205

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161031/e1b1cdf9/attachment.html>