[Differential] [Request, 86 lines] D3206: Fix context help for template data types
antonanikin (Anton Anikin)
noreply at phabricator.kde.org
Sun Oct 30 13:07:04 UTC 2016
antonanikin created this revision.
antonanikin added a reviewer: KDevelop.
antonanikin added a subscriber: kdevelop-devel.
REVISION SUMMARY
This patch fixes broken code-context help for template data types. Old version has buggy behavior:
1. Place following code to some source file:
#include <cmath>
#include <math.h>
#include <vector>
#include <QList>
void test()
{
QList<int> l;
l.append(1);
double x = std::sin(1);
double y = sin(1);
std::vector<int> v;
}
2. Place cursor to any function or templated type and call "Show Documentation" from context menu. Help page is NOT shown.
This behavior caused by wrong usage of documentation Url - we pass full qualified type (with template information like `QList<...>`), but documentation has topics only for plain data type like `QList`.
This fix based on revision https://phabricator.kde.org/D3205 (kdevplatform).
TEST PLAN
Tested on master branch.
REPOSITORY
rKDEVELOP KDevelop
BRANCH
help_templates_fix
REVISION DETAIL
https://phabricator.kde.org/D3206
AFFECTED FILES
documentation/manpage/manpageplugin.cpp
documentation/manpage/manpageplugin.h
documentation/qthelp/qthelpproviderabstract.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antonanikin, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161030/03c52997/attachment.html>
More information about the KDevelop-devel
mailing list