[Differential] [Accepted] D3551: Fix build system issues

patrickelectric (patrick j pereira) noreply at phabricator.kde.org
Wed Nov 30 23:55:15 UTC 2016


patrickelectric accepted this revision.
patrickelectric added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> obogdan wrote in arduinoversion.h.in:1
> I agree that we should use standard ways of doing things, and keeping the style across the project. Considering this, should I replace `#pragma once` across the project with `#ifndef`s ?

@obogdan, disregard my last comment, use #ifdef instead (link <http://stackoverflow.com/questions/787533/is-pragma-once-a-safe-include-guard/1946730#1946730>).

REPOSITORY
  R185 KDevelop Plugin: Embedded Platforms

BRANCH
  fix-buildsystem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3551

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, #kdevelop, kfunk, patrickelectric
Cc: brauch, kfunk, kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161130/5d5b0306/attachment.html>


More information about the KDevelop-devel mailing list