<table><tr><td style="">patrickelectric accepted this revision.<br />patrickelectric added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3551" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3551#inline-13986" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">obogdan</span> wrote in <span style="color: #4b4d51; font-weight: bold;">arduinoversion.h.in:1</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I agree that we should use standard ways of doing things, and keeping the style across the project. Considering this, should I replace <tt style="background: #ebebeb; font-size: 13px;">#pragma once</tt> across the project with <tt style="background: #ebebeb; font-size: 13px;">#ifndef</tt>s ?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/obogdan/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@obogdan</a>, disregard my last comment, use #ifdef instead (<a href="http://stackoverflow.com/questions/787533/is-pragma-once-a-safe-include-guard/1946730#1946730" class="remarkup-link" target="_blank" rel="noreferrer">link</a>).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R185 KDevelop Plugin: Embedded Platforms</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-buildsystem (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3551" rel="noreferrer">https://phabricator.kde.org/D3551</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>obogdan, KDevelop, kfunk, patrickelectric<br /><strong>Cc: </strong>brauch, kfunk, kdevelop-devel, KDevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>