[Differential] [Commented On] D3551: Fix build system issues

[kfunk (Kevin Funk)]

kfunk added a comment.


  Rest LGM

INLINE COMMENTS

> CMakeLists.txt:14
>  find_package(ECM REQUIRED)
> +find_package(KDevPlatform REQUIRED)
>  

Add minimum version while at it: 5.0

> arduinoversion.h.in:1
> +#define ARDUINO_SDK_VERSION "${ARDUINO_SDK_VERSION}"
> +#define ARDUINO_SDK_VERSION_NAME "${ARDUINO_SDK_VERSION_NAME}"

Add header include guards

REPOSITORY
  R185 KDevelop Plugin: Embedded Platforms

REVISION DETAIL
  https://phabricator.kde.org/D3551

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, #kdevelop
Cc: kfunk, kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161130/e53e5b2e/attachment.html>