[Differential] [Request, 173 lines] D3477: Miscellaneous helper cleanups

[flherne (Francis Herne)]

flherne created this revision.
flherne added a reviewer: brauch.
flherne set the repository for this revision to rKDEVPYTHON KDev-python.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  - Simplify some code that was mainly duplicating accessAttribute().
  - Improve accessAttribute() with ideas from the removed copies.
    - Yes, I changed the method signature twice in three patches...
  
  - Replace QList with QVector in internalContextsForClass(), make type ptr const.
  
  - Remove unused return in getDocumentationFileContext().
  - Remove unused -typedef QPair<Declaration*, int> p; in declarationbuilder.cpp.

TEST PLAN
  No test changes/regressions.
  
  No intended changes in behaviour.

REPOSITORY
  rKDEVPYTHON KDev-python

REVISION DETAIL
  https://phabricator.kde.org/D3477

AFFECTED FILES
  codecompletion/context.cpp
  duchain/declarationbuilder.cpp
  duchain/expressionvisitor.cpp
  duchain/helpers.cpp
  duchain/helpers.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161123/7df2dc5b/attachment.html>