[Differential] [Requested Changes To] D3206: Fix context help for template data types

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision now requires changes to proceed.


  Rest LGTM to me

INLINE COMMENTS

> manpageplugin.cpp:108
>          DUChainReadLocker lock;
> -        QualifiedIdentifier qid = dec->qualifiedIdentifier();
> -        if(qid.count() == 1){
> -            if(m_model->identifierInSection(identifier, "3")){
> -                return IDocumentation::Ptr(new ManPageDocumentation(identifier, QUrl("man:(3)/"+identifier)));
> -            } else if(m_model->identifierInSection(identifier, "2")){
> -                return IDocumentation::Ptr(new ManPageDocumentation(identifier, QUrl("man:(2)/"+identifier)));
> -            } else {
> -                return IDocumentation::Ptr(new ManPageDocumentation(identifier, QUrl("man:"+identifier)));
> -            }
> -        }
> +        identifier = dec->qualifiedIdentifier().toString(nullptr);
>      }

While it compiles fine, I find `nullptr` to be really confusing in this context here. Can you use `MyEnum::NoOptions` here?

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D3206

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161116/4571dda7/attachment-0001.html>