<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a reviewer: kfunk.<br />kfunk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3206" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Rest LGTM to me</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3206#inline-13352" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">manpageplugin.cpp:108</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">DUChainReadLocker</span> <span class="n">lock</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="bright"></span><span class="n"><span class="bright">QualifiedI</span>dentifier</span> <span class="bright"></span><span class="n"><span class="bright">qid</span></span><span class="bright"> </span><span style="color: #aa2211">=</span> <span class="n">dec</span><span style="color: #aa2211">-></span><span class="n">qualifiedIdentifier</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">qid</span><span class="p">.</span><span class="n">count</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">m_model</span><span style="color: #aa2211">-></span><span class="n">identifierInSection</span><span class="p">(</span><span class="n">identifier</span><span class="p">,</span> <span style="color: #766510">"3"</span><span class="p">)){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span style="color: #aa4000">return</span> <span class="n">IDocumentation</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">ManPageDocumentation</span><span class="p">(</span><span class="n">identifier</span><span class="p">,</span> <span class="n">QUrl</span><span class="p">(</span><span style="color: #766510">"man:(3)/"</span><span style="color: #aa2211">+</span><span class="n">identifier</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">m_model</span><span style="color: #aa2211">-></span><span class="n">identifierInSection</span><span class="p">(</span><span class="n">identifier</span><span class="p">,</span> <span style="color: #766510">"2"</span><span class="p">)){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span style="color: #aa4000">return</span> <span class="n">IDocumentation</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">ManPageDocumentation</span><span class="p">(</span><span class="n">identifier</span><span class="p">,</span> <span class="n">QUrl</span><span class="p">(</span><span style="color: #766510">"man:(2)/"</span><span style="color: #aa2211">+</span><span class="n">identifier</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span style="color: #aa4000">return</span> <span class="n">IDocumentation</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">ManPageDocumentation</span><span class="p">(</span><span class="n">identifier</span><span class="p">,</span> <span class="n">QUrl</span><span class="p">(</span><span style="color: #766510">"man:"</span><span style="color: #aa2211">+</span><span class="n">identifier</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="bright"></span><span class="n"><span class="bright">i</span>dentifier</span> <span style="color: #aa2211">=</span> <span class="n">dec</span><span style="color: #aa2211">-></span><span class="n">qualifiedIdentifier</span><span class="p">(<span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">toString</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While it compiles fine, I find <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt> to be really confusing in this context here. Can you use <tt style="background: #ebebeb; font-size: 13px;">MyEnum::NoOptions</tt> here?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVELOP KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3206" rel="noreferrer">https://phabricator.kde.org/D3206</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>antonanikin, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, kdevelop-devel<br /></div>