[Differential] [Requested Changes To] D3196: Fix highlighting for problems with incomplete finalLocation

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> problem.cpp:115
> +{
> +    m_finalLocationMode = mode;
> +}

Here: Look at `Problem::finalLocation` and `Problem::setFinalLocation` for inspiration.

> problem.h:241
> +
> +    IProblem::FinalLocationMode m_finalLocationMode;
>  };

This needs to be in `ProblemData` instead. Sorry for not telling you in my earlier review ;)

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3196

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161102/2f7a592f/attachment.html>