[Differential] [Requested Changes To] D3196: Fix highlighting for problems with incomplete finalLocation

kfunk (Kevin Funk) noreply at phabricator.kde.org
Wed Nov 2 09:20:52 UTC 2016


kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> problem.cpp:108
> +{
> +    return IProblem::Range;
> +}

Better implement that properly as well. Just follow the way it's done for the other getters/setters.

> problem.cpp:112
> +void Problem::setFinalLocationMode(IProblem::FinalLocationMode)
> +{
> +}

Dito

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3196

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161102/f1dbdb76/attachment.html>


More information about the KDevelop-devel mailing list