Review Request 129054: [WIP]Port to KF5/KDevelop5

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129054/#review100489
-----------------------------------------------------------



LGTM, just a few minor remarks. Feel free to push after fixing these issues.


CMakeLists.txt (line 3)
<https://git.reviewboard.kde.org/r/129054/#comment67437>

    This shouldn't be needed, *KDECompilerSettings.cmake* sets this



CMakeLists.txt (line 16)
<https://git.reviewboard.kde.org/r/129054/#comment67436>

    Add a minimum required version: 5.0.0



browserappconfig.cpp (line 128)
<https://git.reviewboard.kde.org/r/129054/#comment67438>

    TODO item: Port to categorized logging (qCDebug, etc.) -- not needed in this patch though


- Kevin Funk


On Nov. 1, 2016, 9:29 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129054/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 9:29 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-executebrowser
> 
> 
> Description
> -------
> 
> Port to KF5/KDevelop5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 24ea572d6df7cc3b5fa485e7dff068354e0dfc8c 
>   browserappconfig.h b26c32215dbf15f142aec63fe2ac180bb172c38e 
>   browserappconfig.cpp b7c8a4aed6ed44a069dec57a3e600eeeb8a8ed62 
>   browserappconfig.ui ef205fc6a1edd6cc68e42f5588542a3cd4d764cd 
>   browserappjob.h 37ff7008088706096f73c6da49b46c9234231a0d 
>   browserappjob.cpp a211205aa69b2acc993493b36169c6c1a4cc7b05 
>   cmake/FindKDevPlatform.cmake 1a771c52510cb3e71c19b8a1c84680b6a3c64d08 
>   executebrowserplugin.h 7c787338faeb4fb0749466bb911751c5d72b9093 
>   executebrowserplugin.cpp 95a77aa11ccc97a7625a895032fbb773409cd11e 
>   iexecutebrowserplugin.h f7866227cc8ec0f5946cc78ad35be704ce3aa4f0 
>   kdevexecutebrowser.desktop b5ed913a0f9ed5c4f7b62578f2705560eda48135 
> 
> Diff: https://git.reviewboard.kde.org/r/129054/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161102/5453066c/attachment.html>