<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129054/">https://git.reviewboard.kde.org/r/129054/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">LGTM, just a few minor remarks. Feel free to push after fixing these issues.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129054/diff/4/?file=483808#file483808line4" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${executebrowser_SOURCE_DIR}/cmake)</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set(CMAKE_CXX_STANDARD 11)</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This shouldn't be needed, <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">KDECompilerSettings.cmake</em> sets this</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129054/diff/4/?file=483808#file483808line18" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">find_package(KDevPlatform REQUIRED)</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add a minimum required version: 5.0.0</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129054/diff/4/?file=483810#file483810line129" style="color: black; font-weight: bold; text-decoration: underline;">browserappconfig.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Warning</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Unknown launch mode "</span> <span class="o"><<</span> <span class="n">launchMode</span> <span class="o"><<</span> <span class="s">"for config:"</span> <span class="o"><<</span> <span class="n">cfg</span><span class="o">-></span><span class="n">name</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">128</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Warning</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Unknown launch mode "</span> <span class="o"><<</span> <span class="n">launchMode</span> <span class="o"><<</span> <span class="s">"for config:"</span> <span class="o"><<</span> <span class="n">cfg</span><span class="o">-></span><span class="n">name</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TODO item: Port to categorized logging (qCDebug, etc.) -- not needed in this patch though</p></pre>
</div>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On November 1st, 2016, 9:29 p.m. UTC, Alexander Zhigalin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Zhigalin.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2016, 9:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-executebrowser
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to KF5/KDevelop5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(24ea572d6df7cc3b5fa485e7dff068354e0dfc8c)</span></li>
<li>browserappconfig.h <span style="color: grey">(b26c32215dbf15f142aec63fe2ac180bb172c38e)</span></li>
<li>browserappconfig.cpp <span style="color: grey">(b7c8a4aed6ed44a069dec57a3e600eeeb8a8ed62)</span></li>
<li>browserappconfig.ui <span style="color: grey">(ef205fc6a1edd6cc68e42f5588542a3cd4d764cd)</span></li>
<li>browserappjob.h <span style="color: grey">(37ff7008088706096f73c6da49b46c9234231a0d)</span></li>
<li>browserappjob.cpp <span style="color: grey">(a211205aa69b2acc993493b36169c6c1a4cc7b05)</span></li>
<li>cmake/FindKDevPlatform.cmake <span style="color: grey">(1a771c52510cb3e71c19b8a1c84680b6a3c64d08)</span></li>
<li>executebrowserplugin.h <span style="color: grey">(7c787338faeb4fb0749466bb911751c5d72b9093)</span></li>
<li>executebrowserplugin.cpp <span style="color: grey">(95a77aa11ccc97a7625a895032fbb773409cd11e)</span></li>
<li>iexecutebrowserplugin.h <span style="color: grey">(f7866227cc8ec0f5946cc78ad35be704ce3aa4f0)</span></li>
<li>kdevexecutebrowser.desktop <span style="color: grey">(b5ed913a0f9ed5c4f7b62578f2705560eda48135)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129054/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>