Review Request 127885: Implement color scheme selection from these installed in the system

[Kai Uwe Broulik]

> On Mai 10, 2016, 3:57 nachm., Aleix Pol Gonzalez wrote:
> > This is far too much unrelated code to get in KDevelop, IMHO.
> > 
> > Looks like most of this should/could go to KDE Frameworks (together with KColorScheme?).
> 
> Alexander Zhigalin wrote:
>     Again, I'm not able to and others aren't doing anything for it.
>     See https://bugs.kde.org/show_bug.cgi?id=279592
>     Said that, theme changing is a cool feature that can help us promove KDevelop (Dark-y IDE are quite popular this time).
>     If someone will implement this in Frameworks them we will switch to it, but now is not an option.

What about KColorSchemeManager?

> KColorSchemeManager *manager = new KColorSchemeManager(&app);
> manager->activateScheme(manager->indexForScheme(QStringLiteral("Honeycomb")));

Tada! You now have an app which uses Honeycomb instead of the default sceme. So the app would just need to save the scheme to a config and read it on startup. KColorSchemeManager even has a dropdown control you can use for your app's settings, used by eg. the window rules.

KWin even adjusts and takes the color from the application for the titlebar!

If and only if we want that for all applications, we could put that into KXmlGui so all apps get a setting for that automatically? But anyway, have a look at KColorSchemeManager if you want to add this feature to KDevelop :)


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127885/#review95360
-----------------------------------------------------------


On Mai 10, 2016, 1:11 nachm., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127885/
> -----------------------------------------------------------
> 
> (Updated Mai 10, 2016, 1:11 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 279592
>     http://bugs.kde.org/show_bug.cgi?id=279592
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Implement color scheme selection from these installed in the system.
> Ported from The Digikam Project.
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 752c435b81d60e6bf9d438a0367662a8be346a33 
>   shell/mainwindow.h 8340064ee7e1a3b95695b430270cc848ac69eeac 
>   shell/mainwindow.cpp cf1b15d99365a1274f49bbde18bf3c5c17ba7ccb 
>   shell/mainwindow_p.cpp 70b56db7bed09aeea7a0e57307fb870f65471574 
>   shell/schememanager.h PRE-CREATION 
>   shell/schememanager.cpp PRE-CREATION 
>   shell/thememanager.h PRE-CREATION 
>   shell/thememanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127885/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Color scheme for KTextEditor to use with dark color schemes
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/10/88f4ff18-aa10-426c-85ea-4d4d05c04609__Breeze_Dark.kateschema
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160510/144aef44/attachment-0001.html>