<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127885/">https://git.reviewboard.kde.org/r/127885/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Mai 10th, 2016, 3:57 nachm. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is far too much unrelated code to get in KDevelop, IMHO.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like most of this should/could go to KDE Frameworks (together with KColorScheme?).</p></pre>
</blockquote>
<p>On Mai 10th, 2016, 4:12 nachm. UTC, <b>Alexander Zhigalin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Again, I'm not able to and others aren't doing anything for it.
See https://bugs.kde.org/show_bug.cgi?id=279592
Said that, theme changing is a cool feature that can help us promove KDevelop (Dark-y IDE are quite popular this time).
If someone will implement this in Frameworks them we will switch to it, but now is not an option.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What about KColorSchemeManager?</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KColorSchemeManager *manager = new KColorSchemeManager(&app);
manager->activateScheme(manager->indexForScheme(QStringLiteral("Honeycomb")));</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tada! You now have an app which uses Honeycomb instead of the default sceme. So the app would just need to save the scheme to a config and read it on startup. KColorSchemeManager even has a dropdown control you can use for your app's settings, used by eg. the window rules.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KWin even adjusts and takes the color from the application for the titlebar!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If and only if we want that for all applications, we could put that into KXmlGui so all apps get a setting for that automatically? But anyway, have a look at KColorSchemeManager if you want to add this feature to KDevelop :)</p></pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On Mai 10th, 2016, 1:11 nachm. UTC, Alexander Zhigalin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Zhigalin.</div>
<p style="color: grey;"><i>Updated Mai 10, 2016, 1:11 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279592">279592</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implement color scheme selection from these installed in the system.
Ported from The Digikam Project.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/CMakeLists.txt <span style="color: grey">(752c435b81d60e6bf9d438a0367662a8be346a33)</span></li>
<li>shell/mainwindow.h <span style="color: grey">(8340064ee7e1a3b95695b430270cc848ac69eeac)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(cf1b15d99365a1274f49bbde18bf3c5c17ba7ccb)</span></li>
<li>shell/mainwindow_p.cpp <span style="color: grey">(70b56db7bed09aeea7a0e57307fb870f65471574)</span></li>
<li>shell/schememanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/schememanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/thememanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/thememanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127885/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/05/10/88f4ff18-aa10-426c-85ea-4d4d05c04609__Breeze_Dark.kateschema">Color scheme for KTextEditor to use with dark color schemes</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>