Review Request 127241: Change default CTRL+Click jump to definition instead of declaration

[Milian Wolff]

> On March 1, 2016, 3:38 p.m., Milian Wolff wrote:
> > plugins/contextbrowser/browsemanager.cpp, line 130
> > <https://git.reviewboard.kde.org/r/127241/diff/1/?file=446206#file446206line130>
> >
> >     style: spaces around operators please
> 
> Pedro Ferreira wrote:
>     The code was moved (I didn't add it), but I see your point.

yes, sorry for that. but I try to enforce some sort of consistency when code is touched. I'm aware that large fractions of our old code base do not follow a consistent coding style... we really should run clang-format...


> On March 1, 2016, 3:38 p.m., Milian Wolff wrote:
> > plugins/contextbrowser/browsemanager.cpp, line 159
> > <https://git.reviewboard.kde.org/r/127241/diff/1/?file=446206#file446206line159>
> >
> >     return qMakePair(..., ...);
> 
> Pedro Ferreira wrote:
>     Any reason why we can't just use std::pair ?

You could use that, I don't have anything against that. There is no big advantage over QPair though. And a struct would still win the readability contest every day :)


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127241/#review93006
-----------------------------------------------------------


On March 1, 2016, 4:01 p.m., Pedro Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127241/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 4:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The current default behaviour on CTRL+Click causes the editor do jump to the function's declaration. This patch changes that to jump to definition instead.
> I initially wrote this as a personal hack, but from IRC conversations, it seems that I'm not the only one who's annoyed at this behaviour, so here's my upstream attempt.
> Do note that I know little of the sorrounding code. If you believe further changes are required, I'll need some guidance on that.
> 
> 
> Diffs
> -----
> 
>   plugins/contextbrowser/browsemanager.h f631189 
>   plugins/contextbrowser/browsemanager.cpp 1c5cc70 
> 
> Diff: https://git.reviewboard.kde.org/r/127241/diff/
> 
> 
> Testing
> -------
> 
> It works on my projects and on my KDevPlatform project.
> 
> 
> Thanks,
> 
> Pedro Ferreira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160301/dadf6ea4/attachment.html>