Review Request 127241: Change default CTRL+Click jump to definition instead of declaration

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127241/#review93006
-----------------------------------------------------------


Fix it, then Ship it!




+1 in general, some minor nitpicks from my side


plugins/contextbrowser/browsemanager.h (line 79)
<https://git.reviewboard.kde.org/r/127241/#comment63426>

    unrelated, please remove - we should do that throughout the whole codebase at some point



plugins/contextbrowser/browsemanager.h (line 96)
<https://git.reviewboard.kde.org/r/127241/#comment63425>

    make the function const, and also take the parameters by const&



plugins/contextbrowser/browsemanager.cpp (line 130)
<https://git.reviewboard.kde.org/r/127241/#comment63428>

    style: spaces around operators please



plugins/contextbrowser/browsemanager.cpp (line 132)
<https://git.reviewboard.kde.org/r/127241/#comment63429>

    remove



plugins/contextbrowser/browsemanager.cpp (line 136)
<https://git.reviewboard.kde.org/r/127241/#comment63430>

    auto jumpTo =



plugins/contextbrowser/browsemanager.cpp (line 137)
<https://git.reviewboard.kde.org/r/127241/#comment63431>

    maybe introduce a struct, instead of the pair, and wrap these two isValid checks into a isValid method there



plugins/contextbrowser/browsemanager.cpp (line 143)
<https://git.reviewboard.kde.org/r/127241/#comment63434>

    just make it
    
        DUChainReadLocker lock;



plugins/contextbrowser/browsemanager.cpp (line 159)
<https://git.reviewboard.kde.org/r/127241/#comment63432>

    return qMakePair(..., ...);



plugins/contextbrowser/browsemanager.cpp (line 163)
<https://git.reviewboard.kde.org/r/127241/#comment63433>

    return {};


- Milian Wolff


On March 1, 2016, 3:16 p.m., Pedro Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127241/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 3:16 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The current default behaviour on CTRL+Click causes the editor do jump to the function's declaration. This patch changes that to jump to definition instead.
> I initially wrote this as a personal hack, but from IRC conversations, it seems that I'm not the only one who's annoyed at this behaviour, so here's my upstream attempt.
> Do note that I know little of the sorrounding code. If you believe further changes are required, I'll need some guidance on that.
> 
> 
> Diffs
> -----
> 
>   plugins/contextbrowser/browsemanager.h f631189 
>   plugins/contextbrowser/browsemanager.cpp 1c5cc70 
> 
> Diff: https://git.reviewboard.kde.org/r/127241/diff/
> 
> 
> Testing
> -------
> 
> It works on my projects and on my KDevPlatform project.
> 
> 
> Thanks,
> 
> Pedro Ferreira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160301/eb47a311/attachment-0001.html>