Review Request 128201: Improved StatusbarProgressDidget that looks better on OS X and Linux

René J.V. Bertin rjvbertin at
Sat Jun 18 17:47:36 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated June 18, 2016, 7:47 p.m.)

Review request for KDevelop.


I've spent an afternoon tweaking the StatusbarProgressWidget so it conforms better (IMHO) to the criterium of being the same height as the progressbar. Not easy, as not all widget styles allow control over the progressbar height: on OS X it's considerably taller than `maximumHeight` whereas with Breeze it's considerably thinner.
I think the result isn't too bad though of course finding a solution that works with all tested styles doesn't make the code less complex.

On OS X I didn't find a way to align the pushbutton and the progressbar correctly, so I used `QPushButton::setFlat()` to turn the button into a true icon-only widget which is a bit more in lign with what's usual on the platform. It would be trivial to do this on all platforms; Oxygen already does it (for me) when not hovering over the button, and on Breeze it would probably look better.

Summary (updated)

Improved StatusbarProgressDidget that looks better on OS X and Linux

Repository: kdevplatform


I came across this old bit of code, judging from the use of the deprecated `Q_OS_MAC` token. 
Some quick testing suggests that using `WA_LayoutUsesWidgetRect` achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the `macintosh` widget style btw, rather than "are we running on OS X").

Diffs (updated)

  shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 



For now only on OS X, with the native theme as well as QtCurve, Breeze and Oxygen.

File Attachments (updated)

OS X/Mac native *without* the patch
stock widget under Linux (same layout using Breeze)
OS X/native with the new patch
OS X using QtCurve with the new patch
Linux, Breeze, new patch
Linux, QtCurve, new patch


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list