Review Request 128201: statusbarprogresswidget::m_pButton: use WA_LayoutUsesWidgetRect instead of setMaximumHeight

[René J.V. Bertin]

> On June 17, 2016, 3:35 p.m., Milian Wolff wrote:
> > yes, this is intentional - it should have the same height as the progress bar.
> 
> René J.V. Bertin wrote:
>     I wondered about that. In that case, shouldn't the widget provide its own icon, or at least scale the one from the theme so that it fits?

Or base `maximumHeight` on m_pButton->iconSize().height() if that's larger than the text height, and set the progress bar to that height too?


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128201/#review96628
-----------------------------------------------------------


On June 17, 2016, 12:43 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128201/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 12:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I came across this old bit of code, judging from the use of the deprecated `Q_OS_MAC` token. 
> Some quick testing suggests that using `WA_LayoutUsesWidgetRect` achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the `macintosh` widget style btw, rather than "are we running on OS X").
> 
> 
> Diffs
> -----
> 
>   shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 
> 
> Diff: https://git.reviewboard.kde.org/r/128201/diff/
> 
> 
> Testing
> -------
> 
> For now only on OS X, with the native theme as well as QtCurve, Breeze and Oxygen.
> 
> 
> File Attachments
> ----------------
> 
> Using XCB on OS X: QtCurve
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/9ff50768-0537-4dcc-a84f-5576ff5cc338__Screen_Shot_2016-06-16_at_23.49.59.png
> Using XCB on OS X : Breeze
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/459bf111-6335-408f-9646-8fc601bb046b__Screen_Shot_2016-06-16_at_23.50.30.png
> OS X/Mac native
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/2ad5cf82-354e-462b-b5b6-4f4dcc8803d7__Screen_Shot_2016-06-17_at_00.15.45.png
> OS X/Mac native *without* the patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/1498e8dc-4541-473b-b6db-2c2ae138cbc3__Screen_Shot_2016-06-17_at_00.17.17.png
> stock widget under Linux (same layout using Breeze)
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/17/dd352994-1753-4b33-a0d2-cd2a3132df48__progress-stock.png
> patched widget under Linux, QtCurve
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/17/536a61dc-9b80-4b1d-bf94-c84750bb4d2c__progress-patched.png
> patched widget under Linux, Breeze
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/17/b1628825-e56c-493d-bbc3-8c9c68ddb7d4__progress-patched-breeze.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160617/0b80a62e/attachment-0001.html>