Review Request 128201: statusbarprogresswidget::m_pButton: use WA_LayoutUsesWidgetRect instead of setMaximumHeight

René J.V. Bertin rjvbertin at
Fri Jun 17 10:43:06 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated June 17, 2016, 12:43 p.m.)

Review request for KDevelop.


Screenshots taken under Linux. I'm a bit surprised that the stock widget renders too low for the icon; is that intentional?

Repository: kdevplatform


I came across this old bit of code, judging from the use of the deprecated `Q_OS_MAC` token. 
Some quick testing suggests that using `WA_LayoutUsesWidgetRect` achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the `macintosh` widget style btw, rather than "are we running on OS X").


  shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 



For now only on OS X, with the native theme as well as QtCurve, Breeze and Oxygen.

File Attachments (updated)

Using XCB on OS X: QtCurve
Using XCB on OS X : Breeze
OS X/Mac native
OS X/Mac native *without* the patch
stock widget under Linux (same layout using Breeze)
patched widget under Linux, QtCurve
patched widget under Linux, Breeze


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list