Review Request 128201: statusbarprogresswidget::m_pButton: use WA_LayoutUsesWidgetRect instead of setMaximumHeight

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128201/
-----------------------------------------------------------

(Updated June 17, 2016, 12:30 a.m.)


Review request for KDevelop.


Changes
-------

I'll find some time tomorrow to check if the effect is the same on Linux as on OS X when I use Qt's XCB QPA (= X11). I've attached some screenshots made in that mode.

This also made me realise we'll have to unset the `WA_MacMiniSize` attribute; see the Mac/native screenshot without the patch. Maybe I didn't notice this before because something changed in Qt 5.6.1 which I just installed today. Either way, the button is just not high enough with the original code and the native macintosh theme. It becomes a bit oversized without WA_MacMiniSize, but at least it aligns properly with the progress bar which I don't get otherwise.


Repository: kdevplatform


Description
-------

I came across this old bit of code, judging from the use of the deprecated `Q_OS_MAC` token. 
Some quick testing suggests that using `WA_LayoutUsesWidgetRect` achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the `macintosh` widget style btw, rather than "are we running on OS X").


Diffs
-----

  shell/progresswidget/statusbarprogresswidget.cpp 1a32ea8 

Diff: https://git.reviewboard.kde.org/r/128201/diff/


Testing
-------

For now only on OS X, with the native theme as well as QtCurve, Breeze and Oxygen.


File Attachments (updated)
----------------

Using XCB on OS X: QtCurve
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/9ff50768-0537-4dcc-a84f-5576ff5cc338__Screen_Shot_2016-06-16_at_23.49.59.png
Using XCB on OS X : Breeze
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/459bf111-6335-408f-9646-8fc601bb046b__Screen_Shot_2016-06-16_at_23.50.30.png
OS X/Mac native
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/2ad5cf82-354e-462b-b5b6-4f4dcc8803d7__Screen_Shot_2016-06-17_at_00.15.45.png
OS X/Mac native *without* the patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/1498e8dc-4541-473b-b6db-2c2ae138cbc3__Screen_Shot_2016-06-17_at_00.17.17.png


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160616/1dc2bd75/attachment-0001.html>