Review Request 128012: Check for an existing out-of-source build dir

[Kevin Funk]

> On June 2, 2016, 9:26 p.m., Milian Wolff wrote:
> > project/helper.cpp, line 221
> > <https://git.reviewboard.kde.org/r/128012/diff/3/?file=465463#file465463line221>
> >
> >     I feel really bad with this... Yes - it's powerful, but it's also overkill, no? Who would ever write such a script?

I also think the custom script is overkill. We should just default to sane default paths.

+1 for discarding this idea. Sorry, Rene.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128012/#review96160
-----------------------------------------------------------


On May 25, 2016, 8:24 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128012/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 8:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> When importing a new project, check if it already has a pre-existing out-of-source build directory, and propose that as the build directory in `KDevelop::proposedBuildFolder()`.
> This is comparable to proposing to put the build folder alongside an existing `src` directory (but has priority over that rule).
> 
> 
> Diffs
> -----
> 
>   project/helper.cpp 6df9f90 
> 
> Diff: https://git.reviewboard.kde.org/r/128012/diff/
> 
> 
> Testing
> -------
> 
> Builds and behaves as expected.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160602/0d051608/attachment.html>